Remove duplicated cases in favor of 'aliases' fields #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's common to pull symbols first introduced in extensions to the core spec when SPIR-V version bumps. For such cases, the underlying value remains the same; it's just that we introduce a new symbol (without extension suffix) for it. Thus far we have been creating a entire new case for such cases incorporated into core. It's cluttering the grammar and complicates downstream consumers because downstream consumers need to understand the relationship. It's also quite confusing and error-prone: when introducing a new symbol, it can have different fields than the original one, either meaning subtle differences or caused by oversight. Instead, this commit introduces an 'aliases' field to properly show the relationship between symbols. Other fields describing the value, including 'version', 'extensions', etc., are cleaned up to make sure the canonical symbol collects all the information from duplicated cases. Now if a value has both 'version' and 'extensions', it means the value is available either starting from the given version, or with any of the extensions.
|
closing in favour of #447 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is built on top of #138: the first commit is from #138, so only the second one is interesting here.