Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LiteralFloat to operand_kinds #380

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

rAzoR8
Copy link
Contributor

@rAzoR8 rAzoR8 commented Sep 17, 2023

LiteralFloat was introduced with FPMaxErrorDecorationINTEL, but no entry in operand_kinds corresponds to it. Some codegen tooling might depend on operand_kinds -> category mapping.

This PR adds it with the following "doc" string: "A float consuming one word"
Maybe better wording is necessary.

{
      "category" : "Literal",
      "kind" : "LiteralFloat",
      "doc" : "A float consuming one word"
}

Best,
Fabian

LiteralFloat was introduced with FPMaxErrorDecorationINTEL, but no entry in operand_kinds corresponds to it
Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is definitely an improvement.

I suppose it's possible in the future this could be "a float consuimg one or more words", similar to "LiteralInteger", if we start supporting 64-bit float literals? I think all "LiteralFloats" are currently 32-bits and hence one word, though.

@bashbaug
Copy link
Contributor

Merging as discussed in the September 20th teleconference.

@bashbaug bashbaug merged commit 79743b8 into KhronosGroup:main Sep 20, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants