-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make C++ operator overload for enums not happen for HLSL #386
base: main
Are you sure you want to change the base?
Make C++ operator overload for enums not happen for HLSL #386
Conversation
devsh seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to generate a new file specific to HLSL.
Given the direction HLSL is heading, I'll eventually expect the C++11 file to work without issues. |
Hi @devshgraphicsprogramming, just checking in to ensure you saw the review comment above and aren't waiting on anything from us. Thanks! |
And I responded, wonder if you saw that. |
I think so, do you mean your response:
If this is the case, is this PR needed? Thanks! |
The HLSL 202x project has not committed to this feature, nobody knows if and when they'll add operator overloads. Its probably contingent on proposal 0006 and thats probably years away. A PR is needed either with this or HLSL specific headers which is what I suggested in #385 but got no answer. |
Let's do this by generating a specific file for HLSL, as @dneto suggested above. This way the C++ files remain unchanged and if any other changes are needed for HLSL they can be easily added. @devshgraphicsprogramming can you please update this PR to generate an HLSL-specific file? Thanks! |
…into header_4_hlsl
This allows for inclusion of the headers in HLSL2021 shaders.
Helps with maintenance of large headers of SPIR-V intrinsics (don't need to type out the opcodes by hand).
Fixes #385