Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scope resolution operator in spirv.hpp11 #456

Closed
wants to merge 2 commits into from

Conversation

Christian-Conti
Copy link

The file spirv.hpp11 was missing of the scope resolution operator :: in the cases insde the funcions to separate the namespace from the member

@CLAassistant
Copy link

CLAassistant commented Oct 16, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Christian-Conti
❌ christian.conti


christian.conti seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@Naghasan Naghasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Thanks for your contribution,

The headers are generated by tools not maintained by hand. The process here would be to fix the generator, regenerate the headers and commit all the changes.

In this case I think the issue comes from here
https://github.com/KhronosGroup/SPIRV-Headers/pull/426/files#diff-6b795ceb0e0e4f975be731d875f1df04b8f13003934cb2b2086e78e7c6b10f12R583

@Christian-Conti
Copy link
Author

Christian-Conti commented Oct 17, 2024 via email

@Naghasan
Copy link
Member

closing in favour of #463

@Naghasan Naghasan closed this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants