Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpaquePointers] Correctly find leader of EC in type scavenger #2133

Merged
merged 4 commits into from
Aug 22, 2023

Conversation

LU-JOHN
Copy link
Contributor

@LU-JOHN LU-JOHN commented Aug 21, 2023

Correctly find equivalence class in type scavenger.

…cavenger

Signed-off-by: Lu, John <john.lu@intel.com>
Signed-off-by: Lu, John <john.lu@intel.com>
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LU-JOHN, please, reduce the test case.
136,110 lines doesn't seem reasonable to validate this change.

@bader
Copy link
Contributor

bader commented Aug 21, 2023

@jcranmer-intel, could you take a look, please?

Signed-off-by: Lu, John <john.lu@intel.com>
@LU-JOHN
Copy link
Contributor Author

LU-JOHN commented Aug 22, 2023

Testcase reduced with llvm-reduce.

Copy link
Contributor

@jcranmer-intel jcranmer-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/type-scavenger/equivalence.ll Outdated Show resolved Hide resolved
Signed-off-by: Lu, John <john.lu@intel.com>
@MrSidims MrSidims merged commit e7e8c09 into KhronosGroup:main Aug 22, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants