Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manually convert tests to opaque pointers #2152

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Manually convert tests to opaque pointers #2152

merged 1 commit into from
Sep 13, 2023

Conversation

svenvh
Copy link
Member

@svenvh svenvh commented Sep 8, 2023

Manually convert some tests to opaque pointers that the migration script did not handle correctly.

@svenvh svenvh requested a review from MrSidims September 8, 2023 16:16
vmaksimo
vmaksimo approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@vmaksimo vmaksimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanations, seems good to go :)

@svenvh svenvh merged commit b6c49e3 into KhronosGroup:main Sep 13, 2023
7 checks passed
@svenvh svenvh deleted the opaquify-manual branch September 13, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmaksimo vmaksimo vmaksimo approved these changes

@MrSidims MrSidims Awaiting requested review from MrSidims

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svenvh @vmaksimo