Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport to 14] Backport spirv-preserve-auxdata changes #2178

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

sarnex
Copy link
Contributor

@sarnex sarnex commented Oct 12, 2023

Backport the below changes to 14:

f729c49
89d658c
9823690
d498f48
d24b9c6

I made the following changes that are not in the original changes:

  1. Use llvm::Optional instead of std::optional
  2. Port tests to not use opaque pointers and related flags
  3. Fix patch fail due to missing unrelated function in this branch

…anges

Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
@sarnex sarnex marked this pull request as ready for review October 12, 2023 18:21
@sarnex
Copy link
Contributor Author

sarnex commented Oct 12, 2023

@MrSidims Here's the PR, I'll reuse this change after for 15 and 16 if this looks okay.

@sarnex sarnex changed the title [Backport to 14] Backport preserve-function-metadata-and-attribute changes [Backport to 14] Backport spirv-preserve-auxdata changes Oct 12, 2023
@MrSidims MrSidims merged commit ad3a19e into KhronosGroup:llvm_release_140 Oct 13, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants