Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport to 14][OpaquePointers] Handle llvm.memset intrinsic mangling mismatches. #2181

Merged
merged 2 commits into from
Oct 16, 2023
Merged

[Backport to 14][OpaquePointers] Handle llvm.memset intrinsic mangling mismatches. #2181

merged 2 commits into from
Oct 16, 2023

Commits on Oct 13, 2023

  1. [Backport to 14][OpaquePointers] Handle llvm.memset intrinsic manglin… 

    …g mismatches.

Original change:
KhronosGroup@bdd7652

Non-constant @llvm.memset calls are presently lowered by generating synthetic
functions with the mangled name of memset. However, the reader tries to use this
name to generate the intrinsic call again. This causes verification issues if
the SPIRVWriter and SPIRVReader do not agree on whether or not to use opaque
pointers. This change uses the actual type of the function (which will take into
account whether or not it is in opaque pointer mode) to generate the LLVM
intrinsic name, fixing the mismatch issues.
    @jcranmer-intel @vmaksimo
    jcranmer-intel authored and vmaksimo committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    84ad679 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Add test for reverse translation

    @vmaksimo
    vmaksimo committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    1238e29 View commit details
    Browse the repository at this point in the history