Support sycl_ext_oneapi_prefetch #2189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SYCL part: intel/llvm#11458 intel/llvm#11597 Handle new properties and decorate prefetch's arg.
|
Should the testcase be in test/extensions/SPV_INTEL_cache_controls/? |
LU-JOHN
reviewed
Oct 19, 2023
test/decorate-prefetch-w-cache-controls-sycl-spir64-unknown-unknown.ll
Outdated
Show resolved
Hide resolved
LU-JOHN
reviewed
Oct 24, 2023
test/extensions/INTEL/SPV_INTEL_cache_controls/decorate-prefetch-w-cache-controls.ll
Show resolved
Hide resolved
LU-JOHN
reviewed
Oct 24, 2023
test/extensions/INTEL/SPV_INTEL_cache_controls/decorate-prefetch-w-cache-controls.ll
Show resolved
Hide resolved
LU-JOHN
reviewed
Oct 24, 2023
test/extensions/INTEL/SPV_INTEL_cache_controls/decorate-prefetch-w-cache-controls.ll
Show resolved
Hide resolved
MrSidims
reviewed
Oct 26, 2023
test/extensions/INTEL/SPV_INTEL_cache_controls/decorate-prefetch-w-cache-controls.ll
Outdated
Show resolved
Hide resolved
MrSidims
reviewed
Oct 26, 2023
test/extensions/INTEL/SPV_INTEL_cache_controls/decorate-prefetch-w-cache-controls.ll
Show resolved
Hide resolved
…ch-w-cache-controls.ll Co-authored-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
MrSidims
approved these changes
Oct 26, 2023
|
@MrSidims may we merge it now? |
|
@KornevNikita Can this PR add support for Load and Store? While you need only Load for prefetch, a PR in progress (#11584) will need support for both. Might as well add it now. |
|
Hi @rdeodhar, but the PR is already merged, WDYM? BTW as I see intel/llvm#11584 doesn't use llvm.ptr.annotation intrinsics to generate spirv decorations. It uses spirv.Decorations metadata. The support for these things is already added by #2140, so it requires no additional work for 11584. Am I getting something wrong? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SYCL part: intel/llvm#11458
intel/llvm#11597
Handle new properties and decorate prefetch's arg.