Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Remove Type::getInt8PtrTy after 7b9d73c2f90 #2209

Merged
merged 2 commits into from
Nov 9, 2023
Merged

[NFC] Remove Type::getInt8PtrTy after 7b9d73c2f90 #2209

merged 2 commits into from
Nov 9, 2023

Conversation

MrSidims
Copy link
Contributor

@MrSidims MrSidims commented Nov 8, 2023 •
edited by vmaksimo
Loading

Follow-up to the opaque pointer transition llvm/llvm-project@7b9d73c2f90

@MrSidims
[NFC] Remove Type::getInt8PtrTy after 7b9d73c2f90
2a135d3 
Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
@haonanya haonanya mentioned this pull request Nov 9, 2023
Merged
vmaksimo
vmaksimo reviewed Nov 9, 2023
View reviewed changes
Copy link
Contributor

@vmaksimo vmaksimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use getUnqual as in llvm-project change?
Please also apply clang-format.

@MrSidims
Copy link
Contributor Author

MrSidims commented Nov 9, 2023 •
edited
Loading

Can we use getUnqual as in llvm-project change?

Nope, getUnqual creates a pointer in default address space (and it doesn't have a parameter to specify otherwise).

Please also apply clang-format.

Sure :) I was just having some unrelated test failures in the local branch, which I would like to address first, but don't see them anymore.

@MrSidims
format
87695d5 
Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
@MrSidims MrSidims merged commit 74b2540 into KhronosGroup:main Nov 9, 2023
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmaksimo vmaksimo vmaksimo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrSidims @vmaksimo