support joint matrix prefetch #2212
Merged
+202
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itial introduction of entities related to OpCooperativeMatrixApplyFunctionINTEL
…ooperativeMatrixInvocationInstructionsINTEL capability
not related to the patch |
MrSidims
reviewed
Nov 15, 2023
| @@ -0,0 +1,171 @@ | |||
| ; This is an adapted copy of test/extensions/KHR/SPV_KHR_cooperative_matrix/cooperative_matrix.ll | |||
There was a problem hiding this comment.
Lets name the test appropriately, like cooperative_matrix_prefetch.ll
test/extensions/INTEL/SPV_INTEL_joint_matrix/cooperative_matrix.ll
Outdated
Show resolved
Hide resolved
test/extensions/INTEL/SPV_INTEL_joint_matrix/cooperative_matrix.ll
Outdated
Show resolved
Hide resolved
|
|
||
| ; CHECK-LLVM: call spir_func target("spirv.CooperativeMatrixKHR", i32, 3, 12, 12, 3) @_Z26__spirv_CompositeConstructi(i32 0) | ||
| ; CHECK-LLVM: call spir_func void @_Z38__spirv_CooperativeMatrixPrefetchINTELPU3AS4ciiiiil(ptr addrspace(4) %call.ascast.i66.i, i32 0, i32 0, i32 1, i32 1, i32 0, i64 %_arg_K) | ||
| ; CHECK-LLVM: call spir_func target("spirv.CooperativeMatrixKHR", i8, 0, 12, 48, 3) @_Z86__spirv_CooperativeMatrixLoadKHR_RPU3AS144__spirv_CooperativeMatrixKHR__char_0_12_48_3PU3AS4clii |
There was a problem hiding this comment.
And check for %[[MatrixPtr]] parameter here
| virtual SPIRVValue *getOperand(unsigned I) { | ||
| return getOpValue(I); | ||
| } | ||
| virtual SPIRVValue *getOperand(unsigned I) { return getOpValue(I); } |
There was a problem hiding this comment.
better not to add non-related changes to the patch
There was a problem hiding this comment.
agree, this and following are clang-formats artifacts, I'll revert to the previous state
| @@ -400,12 +398,12 @@ class SPIRVMemoryAccess { | |||
| } | |||
| if (MemoryAccess[0] & MemoryAccessAliasScopeINTELMaskMask) { | |||
| assert(MemoryAccess.size() > MemAccessNumParam && | |||
| "Aliasing operand is missing"); | |||
| "Aliasing operand is missing"); | |||
| ILTPrev = LinkageTypeMax - 2, | ||
| ILTInternal | ||
| }; | ||
| enum InternalLinkageType { ILTPrev = LinkageTypeMax - 2, ILTInternal }; |
There was a problem hiding this comment.
While this suggesting comes from clang-format, probably enums should be better to be split into multiple lines. I'll add ignore format to this file I guess
Co-authored-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
|
@MrSidims thanks for suggestions; can you please check them applied |
|
clang-format is unrelated (and seems like something is no longer working, as it no longer is printing the patch file that should be applied, will take a look tomorrow). |
MrSidims
approved these changes
Nov 15, 2023
MrSidims
pushed a commit
to MrSidims/SPIRV-LLVM-Translator
that referenced
this pull request
Feb 13, 2024
This PR aims to introduce CooperativeMatrixPrefetchINTEL capability and operation, and make initial introduction of entities in llvm-spirv translator.
mateuszchudyk
pushed a commit
to mateuszchudyk/SPIRV-LLVM-Translator
that referenced
this pull request
Mar 26, 2024
This PR aims to introduce CooperativeMatrixPrefetchINTEL capability and operation, and make initial introduction of entities in llvm-spirv translator.
MrSidims
pushed a commit
that referenced
this pull request
Apr 2, 2024
This PR aims to introduce CooperativeMatrixPrefetchINTEL capability and operation, and make initial introduction of entities in llvm-spirv translator. Co-authored-by: Vyacheslav Levytskyy <89994100+VyacheslavLevytskyy@users.noreply.github.com>
YuriPlyakhin
pushed a commit
to YuriPlyakhin/SPIRV-LLVM-Translator
that referenced
this pull request
Jul 3, 2024
This PR aims to introduce CooperativeMatrixPrefetchINTEL capability and operation, and make initial introduction of entities in llvm-spirv translator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to introduce CooperativeMatrixPrefetchINTEL capability and operation, and make initial introduction of entities in llvm-spirv translator.