Can apply MemoryINTEL annotation multiple times on same variable #2230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
vmaksimo
reviewed
Nov 22, 2023
There was a problem hiding this comment.
Change itself looks ok, but we need tests to verify.
The main concern is that specification does not mention that we allow MemoryINTEL decoration several times. Is it a planned change to the spec?
vmaksimo
reviewed
Nov 29, 2023
Comment on lines
33
to
39
| ; CHECK-SPV-IR: [[empty_annot:]] = private unnamed_addr constant [17 x i8] c"{memory:DEFAULT}\00", align 1 | ||
| ; CHECK-SPV-IR: [[mlab_annot:]] = private unnamed_addr constant [14 x i8] c"{memory:MLAB}\00", align 1 | ||
| ; CHECK-SPV-IR: [[block_ram_annot:]] = private unnamed_addr constant [19 x i8] c"{memory:BLOCK_RAM}\00", align 1 | ||
|
|
||
| ; CHECK-LLVM: [[empty_annot:]] = private unnamed_addr constant [17 x i8] c"{memory:DEFAULT}\00", align 1 | ||
| ; CHECK-LLVM: [[mlab_annot:]] = private unnamed_addr constant [14 x i8] c"{memory:MLAB}\00", align 1 | ||
| ; CHECK-LLVM: [[block_ram_annot:]] = private unnamed_addr constant [19 x i8] c"{memory:BLOCK_RAM}\00", align 1 |
There was a problem hiding this comment.
These checks are basically the same, I guess we can have only one tag (e.g., CHECK-LLVM) and check it for both reverse runs. Same for the IR below
Comment on lines
17
to
19
| ; CHECK-SPIRV: Decorate [[#empty:]] MemoryINTEL "DEFAULT" | ||
| ; CHECK-SPIRV: Decorate [[#mlab:]] MemoryINTEL "MLAB" | ||
| ; CHECK-SPIRV: Decorate [[#block_ram:]] MemoryINTEL "BLOCK_RAM" |
There was a problem hiding this comment.
Can I ask you to add checks that prove that we don't generate "DEFAULT" more than once?
artemrad
changed the title
vmaksimo
approved these changes
Nov 30, 2023
MrSidims
reviewed
Nov 30, 2023
MrSidims
approved these changes
Nov 30, 2023
Co-authored-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to SPIRV spec only one instance of a specific decoration can be on a SPIRV-Id, unless the decoration explicitly allows it.
LLVM IR has no such limitation.
MemoryINTELcan have two annotations on the same pointer in LLVM IR. When it comes to translating this to SPIRV, we can filter out the less precise annotation (DEFAULT) and only keep one that will be translated to a SPIRV decoration.