Access out of scope fix in OCLToSPIRVBase::transBuiltin #2262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, nice finding @bwlodarcz |
asudarsa
assigned vmaksimo and VyacheslavLevytskyy and unassigned vmaksimo and VyacheslavLevytskyy
svenvh
approved these changes
Dec 13, 2023
OldRetTy pointer was passed to lambda by reference. This means that in lambda it's real C-like type was Value ** pointing to the stack within of the transBuiltin stack frame. Logic of lambda is executed in doConversion function executed in destructor of BuiltinCallMutator. The stack frame is unaccessible during the destructor call and it worked only as undfined behaviour.
bwlodarcz
force-pushed
the
transBuiltin_fix
branch
from
728281a
to
05f485c
Compare
svenvh
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OldRetTy pointer was passed to lambda by reference. This means that in lambda it's real C-like type was Value ** pointing to the stack within of the transBuiltin stack frame. Logic of lambda is executed in doConversion function executed in destructor of BuiltinCallMutator. The stack frame is inaccessible during the destructor call and it worked only as undefined behavior's.
Fix clears some ASan errors from issue #2233.