-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check to early exit when OpenCL builtin is not found in the map #2525
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Arvind Sudarsanam <arvind.sudarsanam@intel.com>
The fix of the issue is likely a little bigger than "atomic". The changes covers "atomic" prefix but there are other prefixes in |
Hi @bwlodarcz Thanks much for the feedback. Sincerely |
Several user defined/declared functions were being identified as 'possible' OpenCL builtins as they had prefixes (e.g. atomic_) similar to OpenCL builtin function names. However, they were not present in the OCLSPIRVBuiltinMap.
One of the OCLToSPIRV utility functions calls OCLSPIRVBuiltinMap::map function on such user defined functions and this results in a crash.
The correct way to do this will be to check if the OCL function name key is present in the map and exit early if not.
This PR does that.
Thanks