Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport to 17] Add fast math flag translation for OpenCL std lib #2842

Merged

Conversation

MrSidims
Copy link
Contributor

@MrSidims MrSidims commented Nov 7, 2024

Such possibility was added in SPIR-V 1.6.
This patch also introduces limited translation of nofpclass LLVM parameter attribute.

Such possibility was added in SPIR-V 1.6.
This patch also introduces limited translation of nofpclass LLVM parameter attribute.

Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
@MrSidims
Copy link
Contributor Author

MrSidims commented Nov 7, 2024

Clang-tidy error is invalid, RetAttrs is actually used:
/home/runner/work/SPIRV-LLVM-Translator/SPIRV-LLVM-Translator/lib/SPIRV/SPIRVWriter.cpp:2877:24: warning: unused variable 'RetAttrs' [clang-diagnostic-unused-variable]
2877 | AttributeSet RetAttrs = FAttrs.getRetAttrs();

@MrSidims MrSidims merged commit 2fc1351 into KhronosGroup:llvm_release_170 Nov 8, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant