Ensure that PHI node has an incoming value per each predecessor instance even if the input SPIR-V module is invalid #2852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce even if the input SPIR-V module is invalid as reported by spirv-val
VyacheslavLevytskyy
changed the title
VyacheslavLevytskyy
changed the title
MrSidims
approved these changes
Nov 8, 2024
MrSidims
pushed a commit
to MrSidims/SPIRV-LLVM-Translator
that referenced
this pull request
Nov 9, 2024
…nce even if the input SPIR-V module is invalid as reported by spirv-val (KhronosGroup#2852)
MrSidims
pushed a commit
to MrSidims/SPIRV-LLVM-Translator
that referenced
this pull request
Nov 9, 2024
…nce even if the input SPIR-V module is invalid as reported by spirv-val (KhronosGroup#2852)
MrSidims
pushed a commit
to MrSidims/SPIRV-LLVM-Translator
that referenced
this pull request
Nov 9, 2024
…nce even if the input SPIR-V module is invalid as reported by spirv-val (KhronosGroup#2852)
MrSidims
pushed a commit
to MrSidims/SPIRV-LLVM-Translator
that referenced
this pull request
Nov 9, 2024
…nce even if the input SPIR-V module is invalid as reported by spirv-val (KhronosGroup#2852)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of the PR is to ensure that PHI node has an incoming value per each predecessor instance even if the input SPIR-V module is invalid as reported by spirv-val.
This PR fixes solution #2736 intended to fix #2702
This previous version #2736 works well for valid SPIR-V modules, but fails to produce correct LLVM IR if a SPIR-V input is incorrect in terms of OpPhi's number of incoming blocks does not match block's predecessor count.