Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate OpIAddCarry and OpISubBorrow back to llvm intrinsics #2877

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Translate OpIAddCarry and OpISubBorrow back to llvm intrinsics #2877

merged 2 commits into from
Nov 28, 2024

Commits on Nov 25, 2024

  1. Translate OpIAddCarry and OpISubBorrow back to llvm intrinsics 

    Semantically we can translate `OpIAddCarry` and `OpISubBorrow` back into `@llvm.uadd.with.overflow` and `@llvm.usub.with.overflow` respectively.
It require small transformation as there is a difference between return
types in SPIR-V and LLVM IR - e.g., SPIR-V instructions return {i32, i32} struct, but LLVM intrinsics return {i32, i1}.
    @vmaksimo
    vmaksimo committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    cad4141 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Marcos Maronas <marcos.maronas@intel.com>
    @vmaksimo @maarquitos14
    vmaksimo and maarquitos14 authored Nov 26, 2024
    Configuration menu
    Copy the full SHA
    8017aa4 View commit details
    Browse the repository at this point in the history