Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle aliases field in the grammar #5799

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

alan-baker
Copy link
Contributor

This PR requires KhronosGroup/SPIRV-Headers#447.

Handles building tables when the alias entry is present in instructions and enumerants.

Copy link
Collaborator

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks!

* Modify static table generation scripts to include alias lists
* Modify spv_opcode_desc_t and spv_operand_desc_t to include aliases
* Modify opcode and operand lookup by name to also search aliases
@alan-baker alan-baker marked this pull request as ready for review October 9, 2024 15:59
@alan-baker alan-baker enabled auto-merge (squash) October 9, 2024 16:21
@alan-baker alan-baker merged commit fcf994a into KhronosGroup:main Oct 9, 2024
24 checks passed
@alan-baker alan-baker deleted the merge-alias branch October 9, 2024 18:30
dneto0 added a commit to dneto0/shaderc that referenced this pull request Oct 9, 2024
These now use the 'alias' mechanism in the SPIR-V json grammar.
See KhronosGroup/SPIRV-Headers#447
and KhronosGroup/SPIRV-Tools#5799
dneto0 added a commit to google/shaderc that referenced this pull request Oct 9, 2024
These now use the 'alias' mechanism in the SPIR-V json grammar.
See KhronosGroup/SPIRV-Headers#447
and KhronosGroup/SPIRV-Tools#5799
Keenuts pushed a commit to Keenuts/SPIRV-Tools that referenced this pull request Nov 12, 2024
* Modify static table generation scripts to include alias lists
* Modify spv_opcode_desc_t and spv_operand_desc_t to include aliases
* Modify opcode and operand lookup by name to also search aliases

* update vim syntax generator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants