-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle aliases field in the grammar #5799
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-baker
force-pushed
the
merge-alias
branch
from
September 11, 2024 15:27
27841c9
to
2d991f1
Compare
dneto0
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks!
* Modify static table generation scripts to include alias lists * Modify spv_opcode_desc_t and spv_operand_desc_t to include aliases * Modify opcode and operand lookup by name to also search aliases
alan-baker
force-pushed
the
merge-alias
branch
from
October 9, 2024 15:59
0f9ce5f
to
31d834b
Compare
dneto0
added a commit
to dneto0/shaderc
that referenced
this pull request
Oct 9, 2024
These now use the 'alias' mechanism in the SPIR-V json grammar. See KhronosGroup/SPIRV-Headers#447 and KhronosGroup/SPIRV-Tools#5799
dneto0
added a commit
to google/shaderc
that referenced
this pull request
Oct 9, 2024
These now use the 'alias' mechanism in the SPIR-V json grammar. See KhronosGroup/SPIRV-Headers#447 and KhronosGroup/SPIRV-Tools#5799
Keenuts
pushed a commit
to Keenuts/SPIRV-Tools
that referenced
this pull request
Nov 12, 2024
* Modify static table generation scripts to include alias lists * Modify spv_opcode_desc_t and spv_operand_desc_t to include aliases * Modify opcode and operand lookup by name to also search aliases * update vim syntax generator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR requires KhronosGroup/SPIRV-Headers#447.
Handles building tables when the alias entry is present in instructions and enumerants.