Add tests for SYCL_EXTERNAL #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DPCPP version needs a bump for CI to pass. |
ProGTX
approved these changes
Jun 15, 2023
Comment on lines
+74
to
+80
| template <sycl::aspect aspect> | ||
| [[sycl::device_has(aspect)]] SYCL_EXTERNAL [[noreturn]] void | ||
| between_aspects_device(const accT& acc); | ||
| template <> | ||
| SYCL_EXTERNAL void between_aspects_device<sycl::aspect::cpu>(const accT& acc) { | ||
| acc[0] = value; | ||
| } |
There was a problem hiding this comment.
I think this is UB - we can't return normally from a function with [[noreturn]] attribute. See also https://godbolt.org/z/fPTcnKaoT.
There was a problem hiding this comment.
@aelovikov-intel, I opened #780 to fix this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for SYCL_EXTERNAL according to test plan.