Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[group_functions] Reduce test size to avoid overflow #713

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

Nuullll
Copy link
Contributor

@Nuullll Nuullll commented Jun 16, 2023

This avoids meaningless overflowed results for reducing over smaller types (e.g. char).

Signed-off-by: Yilong Guo yilong.guo@intel.com
Co-authored-by: Jie Zhang jiez.zhang@intel.com

@Nuullll Nuullll requested a review from a team as a code owner June 16, 2023 07:48
@vladimirkhashev
Copy link
Contributor

Maybe it make sense to limit the size of the workgroup for reduce tests, because in the case when the size of the workgroup is large enough and the operation type is sycl::multiplies<T>, the test results will also be incorrect due to overflow. Also maybe init value (currently equals to 1442) for reduce operations can be changed that it can be represented by char type?

Copy link
Member

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
You need to fix the merge conflicts.

@Nuullll
Copy link
Contributor Author

Nuullll commented Jun 25, 2023

Thanks. I'll update per @vladimirkhashev 's suggestion.

Signed-off-by: Yilong Guo <yilong.guo@intel.com>
Co-authored-by: Jie Zhang <jiez.zhang@intel.com>
@Nuullll Nuullll changed the title [group_functions] Use size_t binary operator to calculate reduction ref [group_functions] Reduce test size to avoid overflow Jun 25, 2023
@Nuullll
Copy link
Contributor Author

Nuullll commented Jun 25, 2023

Adding co-author: @jiezzhang

@bader bader merged commit 997502d into KhronosGroup:SYCL-2020 Jun 26, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants