Remove checks for bitwise group operations on floating point types #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SYCL 2020 specification defines bitwise operations as being "equivalent" to the binary operators for the given operation. Since the operators are not explicitly defined for `float`, `double` or `sycl::half` the CTS should not test the group reductions with these types and bitwise operations. This commit makes that distinction. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
bader
approved these changes
Jun 21, 2023
…ct_bitwise_float_group_reduce
steffenlarsen
changed the title
ProGTX
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SYCL 2020 specification defines bitwise operations as being "equivalent" to the binary operators for the given operation. Since the operators are not explicitly defined for
float,doubleorsycl::halfthe CTS should not test the group operations with these types and bitwise operations. This commit makes that distinction.