Add checks for reqd_work_group_size for different dimensions and fix test #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bader
approved these changes
Jun 28, 2023
| @@ -650,29 +650,34 @@ void run_separate_lambda(const bool is_exception_expected, | |||
| single_task_action, parallel_for_action, parallel_for_wg_action); | |||
| } | |||
|
|
|||
| template <typename KernelName, typename LambdaItemArg, typename LambdaGroupArg> | |||
| template <typename KernelName, size_t Size = 1, int Dimensions = 1, | |||
There was a problem hiding this comment.
Does using default values make sense in this case? LambdaItemArg has no default value.
There was a problem hiding this comment.
I have tried: they should be deduced from the argument types.
keryell
approved these changes
Jun 28, 2023
| @@ -650,29 +650,34 @@ void run_separate_lambda(const bool is_exception_expected, | |||
| single_task_action, parallel_for_action, parallel_for_wg_action); | |||
| } | |||
|
|
|||
| template <typename KernelName, typename LambdaItemArg, typename LambdaGroupArg> | |||
| template <typename KernelName, size_t Size = 1, int Dimensions = 1, | |||
There was a problem hiding this comment.
I have tried: they should be deduced from the argument types.
Co-authored-by: Ronan Keryell <ronan@keryell.fr>
ProGTX
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added checks for reqd_work_group_size according to updated test plan 2.2. Runtime exception if device doesn’t support required work group size.
Fix tests to use correct attribute.