Test plan for oneapi extension accessor_properties #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test plan according to the oneapi extension accessor_properies spec.
gmlueck
reviewed
Jun 27, 2023
There was a problem hiding this comment.
In general, I think this test should be more focused on features that are specific to the compile-time properties, and it should not duplicate so many generic accessor tests. See my specific comments below for details.
Also, keep in mind that this extension will probably be deprecated before too long and replaced with the more general extension sycl_ext_oneapi_properties. It's still good to have some tests for accessor_properties since it is a supported extension, but we should not go overboard on testing it.
gmlueck
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test plan according to the spec.