Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid some bit_cast in bfloat16 test plan #747

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Avoid some bit_cast in bfloat16 test plan #747

merged 1 commit into from
Jul 10, 2023

Conversation

gmlueck
Copy link
Contributor

@gmlueck gmlueck commented Jul 10, 2023

Addresses a review comment in the test implementation (#738).

@gmlueck
Avoid some bit_cast in bfloat16 test plan
f0f05e5 
Addresses a review comment in the test implementation (KhronosGroup#738).
@gmlueck gmlueck requested a review from a team as a code owner July 10, 2023 13:34
@gmlueck gmlueck mentioned this pull request Jul 10, 2023
Merged
keryell
keryell approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the simplification!

@bader bader merged commit 42ed384 into KhronosGroup:SYCL-2020 Jul 10, 2023
8 checks passed
@gmlueck gmlueck deleted the gmlueck/bfloat16-test-plan branch July 10, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keryell keryell keryell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gmlueck @keryell @bader