Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[group_functions] Insert barrier after each validation #750

Merged
merged 3 commits into from
Jul 27, 2023
Merged

[group_functions] Insert barrier after each validation #750

merged 3 commits into from
Jul 27, 2023

Conversation

Nuullll
Copy link
Contributor

@Nuullll Nuullll commented Jul 17, 2023

Otherwise, the initialization performed by the following code may change the result buffer.

Signed-off-by: Yilong Guo yilong.guo@intel.com

@Nuullll
[group_functions] Insert barrier after each validation
39ae3bd 
Otherwise, the initialization performed by the following code may change
the result buffer.

Signed-off-by: Yilong Guo <yilong.guo@intel.com>
@Nuullll Nuullll requested a review from a team as a code owner July 17, 2023 03:02
@Nuullll
Copy link
Contributor Author

Nuullll commented Jul 21, 2023

gentle ping

keryell
keryell approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good.
More generally, there is a problem in the existing test about just writing full 0 or 1 might hide some bugs. But I guess this is outside of this PR and hopefully the bug would show up in another context.

tests/group_functions/group_barrier.cpp Show resolved Hide resolved
@bader bader merged commit 5db6b84 into KhronosGroup:SYCL-2020 Jul 27, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolmoonen nolmoonen nolmoonen left review comments

@Melirius Melirius Melirius left review comments

@bader bader bader approved these changes

@keryell keryell keryell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Nuullll @bader @keryell @nolmoonen @Melirius