Enable dimension item/id/range dimension checks for DPC++ #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables a number of test cases previously disabled for DPC++ due to missing `dimensions` member in `id`, `range`, `nd_range`, `h_item`, `item`, and `nd_item`. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
bader
approved these changes
Jul 18, 2023
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
steffenlarsen
commented
Jul 20, 2023
| CHECK(sycl::id<3>::dimensions == 3); | ||
| KCHECK(EVAL(sycl::id<1>::dimensions) == 1); | ||
| KCHECK(EVAL(sycl::id<2>::dimensions) == 2); | ||
| KCHECK(EVAL(sycl::id<3>::dimensions) == 3); |
There was a problem hiding this comment.
Note: The names given to the kernel in each instantiation of this test case would previously not be unique, hence the split here.
There was a problem hiding this comment.
This is interesting design information that should appear in a comment.
There was a problem hiding this comment.
Good point. I've added a comment about it.
keryell
approved these changes
Jul 25, 2023
| CHECK(sycl::id<3>::dimensions == 3); | ||
| KCHECK(EVAL(sycl::id<1>::dimensions) == 1); | ||
| KCHECK(EVAL(sycl::id<2>::dimensions) == 2); | ||
| KCHECK(EVAL(sycl::id<3>::dimensions) == 3); |
There was a problem hiding this comment.
This is interesting design information that should appear in a comment.
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables a number of test cases previously disabled for DPC++ due to missing
dimensionsmember inid,range,nd_range,h_item,item, andnd_item.