Make accessor test cases templated on non-type arguments #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the tests for accessors iterate through all combinations of valid arguments each time they try to run a specific section for a specific combination. Though the irrelevant combinations for a given section run no checks or do any significant work, they still introduce an overhead that accumulates, causing it to increase drastically when any of the argument spaces increase, e.g. as the type arguments do in full-conformance mode. To decrease the overhead, this commit changes the accessor tests to use "templated" test cases which each get a combination of arguments and will not check for their relevant sections under other combinations. This should not affect the coverage of the tests, but should decrease the width of the search each section run has to do. Note that this only currently templates the test cases on access mode, dimensions, and targets. Including the types in this to further focus testing runs is left for future work. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
keryell
approved these changes
Jul 25, 2023
…ccessor_test_combinations_templated
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
steffenlarsen
added a commit
to steffenlarsen/SYCL-CTS
that referenced
this pull request
Jul 27, 2023
This commit follows the recent templating style for test combinations introduced on accessors in KhronosGroup#753 to also reduce the overhead for section-lookup in group_scan tests. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
steffenlarsen
added a commit
to steffenlarsen/SYCL-CTS
that referenced
this pull request
Jul 31, 2023
This commit follows the recent templating style for test combinations introduced on accessors in KhronosGroup#753 to also reduce the overhead for section-lookup in group_scan tests. Additionally this unifies the two type_coverage.h files to reduce the maintenance burden of the replicated implementations in them. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
steffenlarsen
added a commit
to steffenlarsen/SYCL-CTS
that referenced
this pull request
Jul 31, 2023
This commit follows the recent templating style for test combinations introduced on accessors in KhronosGroup#753 to also reduce the overhead for section-lookup in group_scan tests. Additionally this unifies the two type_coverage.h files to reduce the maintenance burden of the replicated implementations in them. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the tests for accessors iterate through all combinations of valid arguments each time they try to run a specific section for a specific combination. Though the irrelevant combinations for a given section run no checks or do any significant work, they still introduce an overhead that accumulates, causing it to increase drastically when any of the argument spaces increase, e.g. as the type arguments do in full-conformance mode.
To decrease the overhead, this commit changes the accessor tests to use "templated" test cases which each get a combination of arguments and will not check for their relevant sections under other combinations. This should not affect the coverage of the tests, but should decrease the width of the search each section run has to do.
Note that this only currently templates the test cases on access mode, dimensions, and targets. Including the types in this to further focus testing runs is left for future work.