layers: Update SPIR-V Headers #8679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-ValidationLayers build queued with queue ID 275781. |
spencer-lunarg
commented
Oct 10, 2024
| @@ -132,7 +132,8 @@ const std::unordered_multimap<uint32_t, RequiredSpirvInfo> &GetSpirvCapabilites( | |||
| {spv::CapabilityShaderViewportIndex, {0, &DeviceFeatures::shaderOutputViewportIndex, nullptr, ""}}, | |||
| {spv::CapabilityShaderLayer, {0, &DeviceFeatures::shaderOutputLayer, nullptr, ""}}, | |||
| {spv::CapabilityShaderViewportIndexLayerEXT, {0, nullptr, &DeviceExtensions::vk_ext_shader_viewport_index_layer, ""}}, | |||
| {spv::CapabilityShaderViewportIndexLayerNV, {0, nullptr, &DeviceExtensions::vk_nv_viewport_array2, ""}}, | |||
| // Not found in current SPIR-V Headers | |||
| // {spv::CapabilityShaderViewportIndexLayerNV, {0, nullptr, &DeviceExtensions::vk_nv_viewport_array2, ""}}, | |||
There was a problem hiding this comment.
this looks wrong... looking into it now
There was a problem hiding this comment.
did you figure out what is it?
There was a problem hiding this comment.
yes, this change (while I've wanted it for years) blew things up, about to get a fix up!
KhronosGroup/SPIRV-Headers#447
|
CI Vulkan-ValidationLayers build # 17719 running. |
artem-lunarg
approved these changes
Oct 10, 2024
|
CI Vulkan-ValidationLayers build # 17719 failed. |
|
CI Vulkan-ValidationLayers build queued with queue ID 275885. |
|
CI Vulkan-ValidationLayers build # 17720 running. |
|
CI Vulkan-ValidationLayers build # 17720 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes backward-breaking
AMDXSPIRV-Header update