Do not leak state between adjacent XFB tests #3675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unbind the buffer from the COPY_WRITE_BUFFER target so that it is bound only as XFB for the next test.
lexaknyazev
force-pushed
the
fix-xfb-test
branch
from
b8aa19f
to
8e729d1
Compare
|
@kenrussell This is just a side-effect cleanup so that the actual issue (tested by the code after the new line) is better represented. Passes in Firefox and WebKit, fails in Chromium just like #3476. |
kenrussell
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unbind the buffer from the COPY_WRITE_BUFFER target so that it is bound only as XFB for the next test.