Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent export extensions hook for gather_animation_channel_hook #2337

Closed
marwie opened this issue Sep 2, 2024 · 1 comment · Fixed by #2352
Closed

Inconsistent export extensions hook for gather_animation_channel_hook #2337

marwie opened this issue Sep 2, 2024 · 1 comment · Fixed by #2352
Labels
bug Something isn't working hook

Comments

@marwie
Copy link

marwie commented Sep 2, 2024

Describe the bug

Hello, I currently have a glTF file that fails to export when i have the gather_animation_channel_hook registered in my addon and it turns out that this hook exists twice both in the readme and in the code.

The file exports fine without my addon enabled or when this hook is not added - the bug only appears when my hook is present.

Is this something I can fix on my side or is this a bug in the glTF exporter?

Traceback (most recent call last):
  File "c:\Program Files\Blender Foundation\Blender 4.2\4.2\scripts\addons_core\io_scene_gltf2\io\exp\gltf2_io_user_extensions.py", line 14, in export_user_extensions    hook(*args, export_settings)
TypeError: glTF2ExportUserExtension.gather_animation_channel_hook() takes 7 positional arguments but 8 were given

gather_animation_channel_hook(self, gltf2_animation_channel, channel, blender_object, action_name, node_channel_is_animated, export_settings)

export_user_extensions('gather_animation_channel_hook',

export_user_extensions('gather_animation_channel_hook',

Screenshots
image

.blend file/ .gltf (mandatory)

waterbuffalo.zip

Version

  • OS: Win 10
  • Blender 4.2
@julienduroure julienduroure added bug Something isn't working hook labels Sep 2, 2024
@julienduroure
Copy link
Collaborator

Confirmed

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hook
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants