This PR adds the option to run the produced gltf export through gltfpack with various options #1945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added basic gltfpack options (not hooked up to anything yet)
Added the rest of the currently supported options to the gltfpack command <3
…he file xx_gltfpacked gltfpacked folder is created if not exist
|
|
|
(And you should rebase with main branch, as I fixed some bugs after recent changes in Blender) |
|
Thank you for taking a look :) |
|
Hello, |
donmccurdy
reviewed
Jan 19, 2024
Comment on lines
+224
to
+237
| export_gltfpack_vpi: EnumProperty( | ||
| name='Vertex Position Attributes', | ||
| description='Type to use for vertex position attributes', | ||
| items=(('Integer', 'Integer', 'Use integer attributes for positions'), | ||
| ('Normalized', 'Normalized', 'Use normalized attributes for positions'), | ||
| ('Floating-point', 'Floating-point', 'Use floating-point attributes for positions')), | ||
| default='Integer', | ||
| ) | ||
|
|
||
| export_gltfpack_noq: BoolProperty( | ||
| name='Disable Quantization', | ||
| description='Disable quantization; produces much larger glTF files with no extensions', | ||
| default=True, | ||
| ) |
There was a problem hiding this comment.
I believe these two defaults are in conflict. If quantization is disabled, integer vertex position attributes won't work. I think the uses of the "Vertex Position Attributes" flag in gltfpack are very limited — perhaps it would be best to remove that option from the UI, and just show an option for quantization enabled by default?
This was referenced Jan 19, 2024
|
Thanks @donmccurdy to point it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Juan and I thought of extending this plugin with the option to run the exported glTF through the tool gltfpack (aka meshoptimizer). The main motivation is to get ktx2 support.
By default gltfpack outputs regular .glb/.gltf files that have been optimized for GPU consumption using various cache optimizers and quantization and can also compress textures using Basis Universal format stored in a KTX2 container.
gltfpackwill output to a subfoldergltfpackedin the folder you exported the glTF to.For the plugin to be able to run the originally exported glTF, you need to have
gltfpackinstalled on your system somewhere and configure its path in the plugin preferences, thengltfpackrelevant options will also appear in the export dialog, where you can also decide if you want to make use ofgltfpackor not, among the options you can pass through that tool.Extension in action:
Its preferences too:
Any feedback is welcome