Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note requirements for exact class names #2332

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

Phrogz
Copy link
Contributor

@Phrogz Phrogz commented Aug 30, 2024

The example docs and code previously did not make it clear that the exact class names must be used for the add-on extension to function.

The example docs and code previously did not make it clear
that the exact class names must be used for the add-on
extension to function.
@CLAassistant
Copy link

CLAassistant commented Aug 30, 2024

CLA assistant check
All committers have signed the CLA.

@Phrogz
Copy link
Contributor Author

Phrogz commented Aug 30, 2024

These changes might seem a little pedantic; after all, the README for the exporter does already say "Add a class named …". However, the required class names looked to me like examples, and I spent 3.5 hours trying to figure out why my class (with a different name) wasn't being called, trying to find what I was missing to register my extension so it would be found. I never guessed convention over configuration would be in play. After all, the example files already have other classes like ExampleExtensionProperties.

So, I hope that these changes save some other developer some grief, by being abundantly clear.

@julienduroure
Copy link
Collaborator

Merged, thanks!

@julienduroure julienduroure merged commit 73b2660 into KhronosGroup:main Sep 12, 2024
2 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants