Update artist name #141
Merged
Update artist name #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@javagl The model-index.json changes order because it's not sorted. I've added a sort command on line 785 here: https://github.com/KhronosGroup/glTF-Sample-Assets/pull/126/files#diff-09506a581239de149cd51038a4ec19738712ea024006cb0d91a6e070f3246d63R785 It would be great to get #126 merged sometime, as this is an ongoing problem. |
emackey
approved these changes
Aug 5, 2024
|
See also: d503b02 |
|
Thanks for merging and the hints. The output from #126 looks like it fixed the issue. On the one hand, everybody could just hit 'Merge' there at any time (and in doubt, roll back). But when it touches the PHP code, I'd hestiate to do that without revieving this, and I'd need ... ehrm.. a refresher about PHP to really understand the code changes... |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My name was sometimes my full name, and sometimes my GitHub name. This just changes the metadata JSON to be consistent.
I'm not entirely sure where this commit from the GitHub action comes from, and why it changes the
model-index.json. But this happened automatically, apparently. It only changes the order of certain entries in the JSON, so I assume that this is just some randomness in the order in "dictionaties" in the PHP script...