Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compare base color case #142

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Fix compare base color case #142

merged 2 commits into from
Aug 5, 2024

Conversation

javagl
Copy link
Contributor

@javagl javagl commented Aug 3, 2024

Sorry @echadwick-artist , it's this time not me who is pedantic, but ... the script that I'm working on 🙂

The files had been named
CompareBasecolor.gltf and CompareBasecolor.glb, but should be
CompareBaseColor.gltf and CompareBaseColor.glb

emackey
emackey approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@emackey emackey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The case in model-index.json is still incorrect here, but I believe this file should automatically rebuild and correct itself once this is merged.

@emackey emackey merged commit 1e0a90c into KhronosGroup:main Aug 5, 2024
2 checks passed
@emackey
Copy link
Member

emackey commented Aug 5, 2024

The CI accepted the new filename case into model-index.json automatically in 52c9f0e.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emackey emackey emackey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@javagl @emackey