Skip to content

Commit

Permalink
Merge pull request #480 from KhronosGroup/fix/mimetype
Browse files Browse the repository at this point in the history
Fix loading of images with undefined mimetype [473]
  • Loading branch information
UX3D-haertl committed Jul 20, 2023
2 parents 768bb64 + 6d88503 commit ba6678f
Showing 1 changed file with 37 additions and 1 deletion.
38 changes: 37 additions & 1 deletion source/gltf/image.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { GltfObject } from './gltf_object.js';
import { isPowerOf2 } from './math_utils.js';
import { getExtension } from './utils.js';
import { AsyncFileReader } from '../ResourceLoader/async_file_reader.js';
import { GL } from "../Renderer/webgl";
import { ImageMimeType } from "./image_mime_type.js";
Expand All @@ -14,7 +15,7 @@ class gltfImage extends GltfObject
miplevel = 0,
bufferView = undefined,
name = undefined,
mimeType = ImageMimeType.JPEG,
mimeType = undefined,
image = undefined)
{
super();
Expand Down Expand Up @@ -73,12 +74,41 @@ class gltfImage extends GltfObject
});
}

setMimetypeFromFilename(filename)
{

let extension = getExtension(filename)
if(extension == "ktx2" || extension == "ktx")
{
this.mimeType = ImageMimeType.KTX2;
}
else if(extension == "jpg" || extension == "jpeg")
{
this.mimeType = ImageMimeType.JPEG;
}
else if(extension == "png" )
{
this.mimeType = ImageMimeType.PNG;
}
else
{
console.warn("MimeType not defined");
// assume jpeg encoding as best guess
this.mimeType = ImageMimeType.JPEG;
}

}

async setImageFromUri(gltf)
{
if (this.uri === undefined)
{
return false;
}
if (this.mimeType === undefined)
{
this.setMimetypeFromFilename(this.uri);
}

if(this.mimeType === ImageMimeType.KTX2)
{
Expand Down Expand Up @@ -181,6 +211,12 @@ class gltfImage extends GltfObject
return false;
}

if (this.mimeType === undefined)
{
this.setMimetypeFromFilename(foundFile.name);
}


if(this.mimeType === ImageMimeType.KTX2)
{
if (gltf.ktxDecoder !== undefined)
Expand Down

0 comments on commit ba6678f

Please sign in to comment.