don't return errors on too large requests on a reversed bitreader #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KillingSpark
force-pushed
the
bitreader_no_error
branch
from
ceb03d7
to
41d5a0d
Compare
KillingSpark
force-pushed
the
bitreader_no_error
branch
from
b41f549
to
dcfee3f
Compare
KillingSpark
force-pushed
the
bitreader_no_error
branch
from
dcfee3f
to
fb042b8
Compare
|
This should include a change that checks the decoded FSE tables so that the symbols do match the allowed ranges for literal length, match length and offset which would avoid weird values appearing and would also detect corrupted files earlier and more consistently. (And the code for creating these tables is currently very messy, a cleanup in this module would be nice anyways) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the checks for too large requests (> 56 bits) on a reversed bitreader allows for a whole bunch of error handling in hot loops to be removed which leads to better performance.
Doing this allows more weird values to float around requiring more careful handling of the returned values in many places, more fuzzing is definitely necessary.