further improvements

KingSora · Jun 10, 2024 · 3163809 · 3163809
1 parent f593922
commit 3163809
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 12 deletions.
diff --git a/packages/overlayscrollbars/src/environment.ts b/packages/overlayscrollbars/src/environment.ts
@@ -192,11 +192,9 @@ const createEnvironment = (): Env => {
   return env;
 };
 
-const getEnvironment = (): Env => {
+export const getEnvironment = (): Env => {
   if (!environmentInstance) {
     environmentInstance = createEnvironment();
   }
   return environmentInstance;
 };
-
-export { getEnvironment };
diff --git a/packages/overlayscrollbars/src/support/dom/manipulation.ts b/packages/overlayscrollbars/src/support/dom/manipulation.ts
@@ -1,7 +1,7 @@
 import type { NodeElementTarget, NodeElementTargetCollection } from './types';
 import { createOrKeepArray, each } from '../utils/array';
 import { parent } from './traversal';
-import { bind, noop } from '../utils';
+import { bind } from '../utils';
 
 /**
  * Removes the given Nodes from their parent.
@@ -21,11 +21,11 @@ export const removeElements = (nodes: NodeElementTargetCollection): void => {
  * @returns A function which removes the inserted nodes.
  */
 export const appendChildren = (node: NodeElementTarget, children: NodeElementTargetCollection) =>
-  node && children
-    ? bind(
-        removeElements,
-        each(createOrKeepArray(children), (child) => {
-          child && node.appendChild(child);
-        })
-      )
-    : noop;
+  bind(
+    removeElements,
+    node &&
+      children &&
+      each(createOrKeepArray(children), (child) => {
+        child && node.appendChild(child);
+      })
+  );