Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace mock-fs with memfs #129

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

ookkoouu
Copy link

@ookkoouu ookkoouu commented Oct 8, 2024

Description

mock-fs doesn't work on NodeJS 20, use memfs instead.
https://github.com/streamich/memfs

All tests passed in NodeJS 22.9.0.

Implementation Notes

  • mock fs fs/promises in all tests
  • removed yazl, use adm-zip
    • yazl was used to create a dummy zip file, but the tests timed out, so it was replaced with adm-zip, which has a synchronous method available.

Checklist

  • Added unit tests for every exported function/class.
  • Added JSDoc to every public function/class/class member.
  • Added relevant information to the README.

@Kir-Antipov
Copy link
Owner

Thanks for being an absolute MVP! :D
I haven't started working on the tests yet, so I really appreciate you making this part easier for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants