fix(Group): handle visibility for nested groups #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you run |
ChristosT
force-pushed
the
fix-group-in-group
branch
from
8064b3e
to
a2e6b06
Compare
jourdain
reviewed
Aug 21, 2023
| @@ -33,14 +33,21 @@ export default { | |||
| } | |||
|
|
|||
| let visibleCount = 0; | |||
| this.$slots.default.forEach((vNode) => { | |||
| let helper = (vNode) => { | |||
|
Looks good otherwise |
ChristosT
force-pushed
the
fix-group-in-group
branch
from
a2e6b06
to
06fc6d9
Compare
When a group has another group as only child, its slot may not have an associated
`componentInstance`. In this case we need to look in its children for componentInstances to check for visibility.
This was found in async_paraview when using the stream tracer filter with the following layout.
```
<SourceProxy StreamTracer ...>
<PropertyGroup label="Seeds">
<Property name="Source"/>
<PropertyGroup label="Line Parameters" panel_widget="InteractiveLine">
...
</PropertyGroup>
</PropertyGroup>
</SourceProxy>
```
Since we do not have `InteractiveLine` widget yet and we replace it with a group and thus a nested group is created.
ChristosT
force-pushed
the
fix-group-in-group
branch
from
06fc6d9
to
77490d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a group has another group as only child its slot may not have an associated
componentInstance. In this case we need to look in its children for componentInstances to check for visibility of the group.This was found in async_paraview when using the stream tracer filter with the following layout.
Since we do not have
InteractiveLinewidget yet and we replace it with a group and thus a nested group is created.