Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(proxy): make ProxyManager.load return _id_remap #21

Merged
merged 1 commit into from
May 14, 2024

Conversation

bourdaisj
Copy link
Contributor

This can be useful when one is restoring a simput state and keeps around the old proxy ids in its own managed state.
This way they can keep both state in sync.

@bourdaisj bourdaisj requested a review from jourdain May 14, 2024 15:18
@jourdain
Copy link
Collaborator

Looks good but you need to rework your commit message to be compatible with semantic release.

fix(proxy): make ProxyManager.load return _id_remap

@bourdaisj
Copy link
Contributor Author

Yep, thanks, my bad. Done!

@jourdain jourdain merged commit 175d92d into Kitware:master May 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants