Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scanline iterator RLEImage macOS #63

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

thewtex
Copy link
Member

@thewtex thewtex commented Apr 1, 2024

This addresses
InsightSoftwareConsortium/ITK#4537

In addition to SmartPointer arguments, we need a raw const pointer version.

Suggested-by: Niels Dekker N.Dekker@lumc.nl

This addresses
InsightSoftwareConsortium/ITK#4537

In addition to SmartPointer arguments, we need a raw const pointer
version.

Suggested-by: Niels Dekker <N.Dekker@lumc.nl>
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are CTADs needed for other iterator types in this remote module?

include/itkRLEImageScanlineIterator.h Show resolved Hide resolved
@dzenanz
Copy link
Member

dzenanz commented Apr 1, 2024

@jilei-hao can you check this PR too?

@jilei-hao
Copy link

@jilei-hao can you check this PR too?

It works! Thanks so much!

@jilei-hao
Copy link

jilei-hao commented Apr 2, 2024

And it works even without the changes in InsightSoftwareConsortium/ITK#4553

@dzenanz dzenanz merged commit 85559c9 into KitwareMedical:master Apr 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants