Skip to content

Commit

Permalink
Merge pull request #299 from garak/fix-deprecation
Browse files Browse the repository at this point in the history
fix deprecations
  • Loading branch information
weaverryan authored Jan 5, 2022
2 parents c6101a4 + 9cd7a0a commit 33d0d36
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
uses: actions/checkout@v2
- run: |
phpenv config-rm xdebug.ini || true
composer global require --no-progress --no-scripts --no-plugins symfony/flex dev-main
composer global require --no-progress --no-scripts --no-plugins symfony/flex 1.*
- name: Cache
uses: actions/cache@v2
with:
Expand All @@ -56,4 +56,4 @@ jobs:
- run: composer config minimum-stability dev && composer config prefer-stable true
if: matrix.dev
- run: composer update --no-interaction --no-progress --ansi ${{ matrix.composer_option }}
- run: vendor/bin/simple-phpunit -v
- run: vendor/bin/simple-phpunit -v
2 changes: 1 addition & 1 deletion src/DependencyInjection/Configuration.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class Configuration implements ConfigurationInterface
/**
* {@inheritdoc}
*/
public function getConfigTreeBuilder()
public function getConfigTreeBuilder(): TreeBuilder
{
$fixOptionKeys = function ($options) {
$fixedOptions = [];
Expand Down
2 changes: 1 addition & 1 deletion src/DependencyInjection/KnpSnappyExtension.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class KnpSnappyExtension extends Extension
/**
* {@inheritdoc}
*/
public function load(array $configs, ContainerBuilder $container)
public function load(array $configs, ContainerBuilder $container): void
{
$loader = new XmlFileLoader($container, new FileLocator(__DIR__ . '/../../config'));

Expand Down
4 changes: 2 additions & 2 deletions src/KnpSnappyBundle.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,15 @@ class KnpSnappyBundle extends BaseBundle
/**
* {@inheritdoc}
*/
public function getNamespace()
public function getNamespace(): string
{
return __NAMESPACE__;
}

/**
* {@inheritdoc}
*/
public function getPath()
public function getPath(): string
{
return strtr(__DIR__, '\\', '/');
}
Expand Down
2 changes: 1 addition & 1 deletion tests/TestKernel.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public function setConfigurationFilename($filename)
/**
* {@inheritdoc}
*/
public function registerBundles()
public function registerBundles(): iterable
{
return [
new \Symfony\Bundle\FrameworkBundle\FrameworkBundle(),
Expand Down

0 comments on commit 33d0d36

Please sign in to comment.