Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overridable g1 texture filters #873

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

sh-dave
Copy link
Contributor

@sh-dave sh-dave commented Apr 11, 2024

Is g1 expected to be used with render targets, or is it more of an example and you expect users to do the rendering into the framebuffer manually?

With this PR it's possible to override the texture filter settings via extern declarations.

extern kinc_g4_texture_filter_t kinc_internal_g1_texture_minf;
extern kinc_g4_texture_filter_t kinc_internal_g1_texture_magf;

int main(...) {
...
  kinc_internal_g1_texture_minf = KINC_G4_TEXTURE_FILTER_POINT;
  kinc_internal_g1_texture_magf = KINC_G4_TEXTURE_FILTER_POINT;
...
}

I'm currently just playing a bit with the render targets, so feel free to just close this if it doesn't fit.

@RobDangerous
Copy link
Member

"internal" means please only touch this internally so that doesn't quite fit. Making it fit for render-target use would be nice though.

@sh-dave
Copy link
Contributor Author

sh-dave commented Apr 18, 2024

Ok, added some setter functions. Not sure if the separate enum is overkill, but it felt kinda weird to include and use G4 types in the public api.

@RobDangerous
Copy link
Member

It's good like that with those enums. And it's going in, thanks!

@RobDangerous RobDangerous merged commit 89b4155 into Kode:main Apr 18, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants