Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an assert for stb_vorbis_decode_memory call #880

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Add an assert for stb_vorbis_decode_memory call #880

merged 1 commit into from
Aug 8, 2024

Conversation

jgraj
Copy link
Contributor

@jgraj jgraj commented Aug 8, 2024

Return value of stb_vorbis_decode_memory is less than 0 for errors and we later malloc with that value, so 0 is still probably not good to have

Return value of `stb_vorbis_decode_memory` is less than 0 for errors and we later malloc with that value, so 0 is still probably not good to have
@RobDangerous RobDangerous merged commit 7ccdd1c into Kode:main Aug 8, 2024
20 checks passed
@jgraj
Copy link
Contributor Author

jgraj commented Aug 8, 2024

Also there are kinc_affirm and assert calls used seemingly randomly so I didn't know which one to use

@jgraj jgraj deleted the patch-1 branch August 8, 2024 07:15
@RobDangerous
Copy link
Member

kinc_affirm is active in release-builds, assert is not. Choose wisely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants