feat(sia): Sia Wallet functionality #2221
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se it via coins::siacoin::sia_rust. Allows KDF to import sia-rust in a single location
define sia typed equivalent of coins::RefundPaymentArgs, SiaRefundPaymentArgs. - add RefundPaymentArgs->SiaRefundPaymentArgs parsing and error handling
…ker_payment_then_spend_taker_payment to sia mm2_main tests
…aker_payment_then_refund_taker_payment
…Coin::from_conf_and_request
refactors various errors to fit new error handling patterns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog(still WIP):
CI builds are changed to print a sha256 hash of the binary to CI log
This allows us to double check the binary produced by CI is actually the one being hosted.
"--cfg", "feature="enable-sia""
This is removed from
.cargo/config.toml. This was placed by Omar. I don't know why.Removed a dep install from GH action - ref:1c8715d4058e378fce0caa6cec54a03d488f055e
I don't know why this was initially placed here.
Set
--all-featuresin all cargo/rustc commands for all CI except release builds.This seems the most sensible way of doing this as otherwise we won't be running feature-gated tests or finding feature specific bugs or clippy warnings
The updated
sia-rustcode must also be reviewed:KomodoPlatform/sia-rust@9f188b8...komodoplatform:dev