Rename "SunriseIDE.emulators.ROM" file to "SunriseIDE.blueMSX.ROM" #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue of only recognizing the slave device with the regular Sunrise IDE driver happens only in blueMSX, not in all emulators as the documentation was incorrectly stating.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "emulators" variant, using an old driver for Sunrise IDE, was created due to an issue noticed in the blueMSX emulator with the current IDE driver (only the slave device is found) that doesn't happen with the old driver. The corresponding ROM file was given the extension
SunriseIDE.emulators.ROMunder the incorrect assumption that the issue was present in all the existing MSX emulators.This pull request modifies the makefile so that the generated file will have extension
SunriseIDE.emulators.ROMinstead, and updates the getting started guide accordingly.Closes #112.