Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: multiple tabs - [INS-4225] #8151

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

WIP: multiple tabs - [INS-4225] #8151

wants to merge 17 commits into from
+1,280 −59

Conversation

CurryYangxx
Copy link
Member

@CurryYangxx CurryYangxx commented Nov 6, 2024 •
edited
Loading

Changes

  • create a TabList and Tab Component, and import it in every type of file page.
  • store tab data in localstorage, use InsomniaTabContext to manage state of the tabs
  • create a useInsomniaTab hook
    • get tab type according to the location pathname
    • check if tab exist
    • pack tab data
    • add new tab
  • sync tab data with db
  • click "+" to add tab
  • remove debug logs
image

@CurryYangxx CurryYangxx marked this pull request as draft November 6, 2024 03:42
@CurryYangxx CurryYangxx changed the title WIP: multiple tabs WIP: multiple tabs - [INS-4225] Nov 6, 2024
@CurryYangxx CurryYangxx force-pushed the feat/multiple-tab branch 3 times, most recently from 9958030 to a8d050d Compare November 15, 2024 07:45
@CurryYangxx CurryYangxx marked this pull request as ready for review November 18, 2024 10:35
filfreire
filfreire reviewed Nov 18, 2024
View reviewed changes
Copy link
Member

@filfreire filfreire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Found issue where tabs disappear when pressing OPTION + TAB in the UI after a few times

some suggestions for this PR or other follow-up PRs:

  • allow for pressing CTRL + TAB / CTRL + SHIFT + TAB to alternate between tabs
  • perhaps also allow the same for pressing CTRL + 1 (1 to 9) to go to 1st -> 9th tab, 0 being last tab?
  • allow middle-mouse click to close a tab
  • capture COMMAND+W (and windows/linux equivalent) to close tabs

@filfreire filfreire requested a review from a team November 18, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filfreire filfreire filfreire left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CurryYangxx @filfreire