fix(aws-lambda): add better type and error handling on proxy integration mode #11413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…proxy integration test for sam
ADD-SP
approved these changes
Aug 16, 2023
windmgc
added a commit
that referenced
this pull request
Nov 2, 2023
…ion mode (#11413) * tests(aws-lambda): add response content type for multiple tests, add proxy integration test for sam * fix(aws-lambda): better type & error handling when extracting proxy response * tests(aws-lambda): fix test * docs(changelog): add missing changelog
3 tasks
windmgc
added a commit
that referenced
this pull request
Nov 3, 2023
…ion mode (#11413) * tests(aws-lambda): add response content type for multiple tests, add proxy integration test for sam * fix(aws-lambda): better type & error handling when extracting proxy response * tests(aws-lambda): fix test * docs(changelog): add missing changelog
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds better type handling and error handling for proxy integration mode. One change comes from #11350 is that if lambda function's response body is
application/jsonthen it will be automatically decoded by AWS lib. We handle this situation better and make sure it gets tested in our integration test.Checklist
Full changelog