refactor(build): use kong_template_* rule for luarocks targets #11418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
release tarball to install private rocks
fffonion
force-pushed
the
private-luarocks
branch
from
771537e
to
42559ac
Compare
windmgc
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the luarocks build targets by using the improved
kong_template_fileandkong_template_genrulerules so that we don't need to write shell scripts in multipl escapes and complex templates.Checklist
CHANGELOG.mdFull changelog
Issue reference
KAG-2351
EE sister PR https://github.com/Kong/kong-ee/pull/6294
KAG-1387