fix(PDK): fix response body repeated when kong.response.get_raw_body() called multiple times #11424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vm-001
commented
Aug 18, 2023
| --- request | ||
| GET /t | ||
| --- response_body | ||
| hello, world! |
There was a problem hiding this comment.
The response gets repeated if the fix is not applied: hello, world!hello, world!
bungle
approved these changes
Aug 18, 2023
|
Great! |
…) called multiple times
bungle
force-pushed
the
fix/repeated-response-when-get-raw-body-called-multiple-times
branch
from
e1128f0
to
bd54a42
Compare
vm-001
force-pushed
the
fix/repeated-response-when-get-raw-body-called-multiple-times
branch
from
c6f090b
to
18b04fd
Compare
bungle
approved these changes
Aug 21, 2023
bungle
deleted the
fix/repeated-response-when-get-raw-body-called-multiple-times
branch
|
Does this Should we remove it now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ngx.ctx.KONG_BODY_BUFFER is not reset while reading the EOF chunk. When
kong.response.get_raw_body()is called multiple times, the response body gets repeated.Checklist
Issue reference
FTI-5296